-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @Dependency(MyDependency.self)
#172
Merged
Merged
+257
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Jan 22, 2024
@@ -58,7 +58,7 @@ | |||
/// implementation module. | |||
/// | |||
/// See the <doc:LivePreviewTest> article for more information. | |||
public protocol DependencyKey: TestDependencyKey { | |||
public protocol DependencyKey<Value>: TestDependencyKey { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snuck this feature into the branch, but could extract to a separate PR...
stephencelis
changed the title
Add support for
Add support for Jan 22, 2024
@Dependency(Dependency.self)
@Dependency(MyDependency.self)
mbrandonw
approved these changes
Jan 22, 2024
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
@Environment
supports a shorthand for objects, we should do similar in our library.This PR allows you to skip the step of extending
DependencyValues
with a key path and instead rely directly on the dependency key, which usually aligns with the value.This new API is less discoverable and friendly to autocomplete, but may be appropriate for application code that refers to a singleton type, and can save that bit of boilerplate above.